Skip to content

chore: Add @JsonCreator to McpError #768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
He-Pin wants to merge 2 commits into
base: main
Choose a base branch
from
Open

chore: Add @JsonCreator to McpError #768

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
89629b9
chore: Add @JsonCreator to McpError
He-Pin Feb 2, 2026
e8e5ed8
Merge branch 'main' into creator
He-Pin Feb 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions mcp-core/src/main/java/io/modelcontextprotocol/spec/McpError.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

package io.modelcontextprotocol.spec;

import com.fasterxml.jackson.annotation.JsonCreator;
import io.modelcontextprotocol.spec.McpSchema.JSONRPCResponse.JSONRPCError;
import io.modelcontextprotocol.util.Assert;

Expand All @@ -22,6 +23,10 @@ public class McpError extends RuntimeException {

private JSONRPCError jsonRpcError;

/**
* Add @JsonCreator to make sure Jackson can deserialize it properly.
*/
@JsonCreator
public McpError(JSONRPCError jsonRpcError) {
Copy link

Copilot AI Feb 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When using @JsonCreator with a single-parameter constructor, it's recommended to explicitly annotate the constructor parameter with @JsonProperty to ensure reliable deserialization across different Jackson configurations. While the current code may work due to the -parameters compiler flag, adding @JsonProperty("jsonRpcError") to the constructor parameter would make the deserialization contract explicit and more robust.

This follows the pattern seen throughout the codebase where all record constructors explicitly use @JsonProperty annotations on their parameters (e.g., JSONRPCError in McpSchema.java:306-308).

Copilot uses AI. Check for mistakes.
super(jsonRpcError.message());
this.jsonRpcError = jsonRpcError;
Expand Down
Loading