refactor: remove deprecated 0.7.0 code #66
Conversation
These changes are part of the planned deprecation cycle announced in 0.8.0, with the deprecated classes scheduled for removal in 0.9.0 - Delete WebFluxSseServerTransport, WebMvcSseServerTransport, StdioServerTransport, and HttpServletSseServerTransport - Remove deprecated interfaces: ServerMcpTransport, ClientMcpTransport - Delete DefaultMcpSession implementation - Remove all deprecated test classes for the removed implementations - Update references to use McpServerTransport and McpClientTransport interfaces Signed-off-by: Christian Tzolov <christian.tzolov@broadcom.com>
| @@ -71,7 +71,7 @@ public class McpSyncClient implements AutoCloseable { | |||
| */ | |||
| @Deprecated | |||
There was a problem hiding this comment.
Looks like this deprecation annotation is incorrect
There was a problem hiding this comment.
It is correct. The intention was to allow us to hide the visibility in 0.9.0. We can also remove the deprecated javadoc note above now.
| * interfaces. | ||
| */ | ||
| public class MockMcpTransport implements McpClientTransport, ServerMcpTransport { | ||
| public class MockMcpTransport implements McpClientTransport, McpServerTransport { |
There was a problem hiding this comment.
Looks like we need to split the MockMcpTransport to client and server mocks.
There was a problem hiding this comment.
Resolved in the last commit
mcp/src/test/java/io/modelcontextprotocol/server/McpServerProtocolVersionTests.java
Outdated
Show resolved
Hide resolved
- Rename MockMcpTransport to MockMcpClientTransport in mcp/src/test - Create new MockMcpServerTransport implementation - Add MockMcpServerTransportProvider for server tests - Mark MockMcpTransport in mcp-test module as deprecated - Update all test classes to use the new implementations Signed-off-by: Christian Tzolov <christian.tzolov@broadcom.com>
| @@ -71,7 +71,7 @@ public class McpSyncClient implements AutoCloseable { | |||
| */ | |||
| @Deprecated | |||
There was a problem hiding this comment.
It is correct. The intention was to allow us to hide the visibility in 0.9.0. We can also remove the deprecated javadoc note above now.
| return Mono.defer(() -> { | ||
| return Mono.empty(); | ||
| }); | ||
| } |
There was a problem hiding this comment.
No need for defer. return Mono.empty() is enough.
Signed-off-by: Christian Tzolov <christian.tzolov@broadcom.com>
|
rebased, squashed and merged at 25f3bad |
These changes are part of the planned deprecation cycle announced in 0.8.0, with the deprecated classes scheduled for removal in 0.9.0