implement completions #141
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jitokim <pigberger70@gmail.com>
Signed-off-by: jitokim <pigberger70@gmail.com>
jitokim
force-pushed
the
serverCapabilities-completions
branch
from
8306a87 to
98450f7
Compare
Signed-off-by: jitokim <pigberger70@gmail.com>
jitokim
force-pushed
the
serverCapabilities-completions
branch
from
98450f7 to
09cbe0a
Compare
Signed-off-by: jitokim <pigberger70@gmail.com>
jitokim
force-pushed
the
serverCapabilities-completions
branch
from
c683541 to
768d123
Compare
jitokim
changed the title
|
Thanks 😀 |
tzolov
pushed a commit
that referenced
this pull request
Apr 16, 2025
Add completion API support to the MCP protocol implementation: - Add CompleteRequest and CompleteResult schema classes - Implement completion capabilities in ServerCapabilities - Add completion handlers in McpAsyncServer and McpServer - Add completion client methods in McpAsyncClient and McpSyncClient - Add CompletionRefKey and completion specifications in McpServerFeatures - Add integration test for completion functionality - Fix isPresent() check to use isEmpty() in WebMvcSseServerTransportProvider Signed-off-by: jitokim <pigberger70@gmail.com>
tzolov
pushed a commit
that referenced
this pull request
Apr 16, 2025
Add completion API support to the MCP protocol implementation: - Add CompleteRequest and CompleteResult schema classes - Implement completion capabilities in ServerCapabilities - Add completion handlers in McpAsyncServer and McpServer - Add completion client methods in McpAsyncClient and McpSyncClient - Add CompletionRefKey and completion specifications in McpServerFeatures - Add integration test for completion functionality - Fix isPresent() check to use isEmpty() in WebMvcSseServerTransportProvider Signed-off-by: jitokim <pigberger70@gmail.com>
tzolov
pushed a commit
that referenced
this pull request
Apr 16, 2025
Add completion API support to the MCP protocol implementation: - Add CompleteRequest and CompleteResult schema classes - Implement completion capabilities in ServerCapabilities - Add completion handlers in McpAsyncServer and McpServer - Add completion client methods in McpAsyncClient and McpSyncClient - Add CompletionRefKey and completion specifications in McpServerFeatures - Add integration test for completion functionality - Fix isPresent() check to use isEmpty() in WebMvcSseServerTransportProvider - Replace McpServerFeatures.CompletionRefKey by McpSchemaCompleteReference Co-authored-by: Christian Tzolov <christian.tzolov@broadcom.com> Signed-off-by: jitokim <pigberger70@gmail.com>
|
@jitokim, fyi, I've made some changes like replacing the McpServerFeatures#CompletionRefKey by McpSchema#CompleteReference ... |
|
That is a better name indeed. Appreciate the update. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Add the initial implementation for completion
How Has This Been Tested?
add integration test named
testCompletionShouldReturnExpectedSuggestionsBreaking Changes
Types of changes
Checklist
Additional context