Skip to content

chore: Add engines to package-lock.json #583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

richardkmichael
Copy link
Collaborator

Clone and run npm install; package-lock.json immediately has changes -- engines are added.

Motivation and Context

Running npm install after a fresh clone should not result in any changes to NPM files.

I suspect this was missed in PR #473

How Has This Been Tested?

npm run test and npm run test:e2e both pass all tests.

Breaking Changes

No

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

@richardkmichael richardkmichael changed the title chone: Add engines to package-lock.json chore: Add engines to package-lock.json Jul 4, 2025
Copy link
Member

@cliffhall cliffhall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@cliffhall cliffhall merged commit e76bb0a into modelcontextprotocol:main Jul 4, 2025
4 checks passed
@richardkmichael richardkmichael deleted the node-engine-lock branch August 1, 2025 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants