fix: Restore JSONForm array when all items are simple items #434
+70
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @max-stytch I tried testing with a schema based on the shape you linked to but when I click the Add Item button, it doesn't show a field like it does in your screenshot. Have I got the schema wrong? 
test-form.mov |
cliffhall
added
the
waiting on submitter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Partially resolves of #332 - this PR restores the array logic that was removed in #284, but only when all nested objects are also "simple" objects.
How Has This Been Tested?
Validated against the JSON schema in this comment - nested items are rendered appropriately
Breaking Changes
Types of changes
Checklist
Additional context