Fix connection issue for servers with auth #418
Conversation
client/src/components/ToolsTab.tsx
Outdated
| @@ -82,7 +82,7 @@ const ToolsTab = ({ | |||
| <span className="text-green-600 font-semibold">Success</span> | |||
| )} | |||
| </h4> | |||
| {structuredResult.content.map((item, index) => ( | |||
| {structuredResult.content?.map((item, index) => ( | |||
There was a problem hiding this comment.
unrelated, build was not happy
There was a problem hiding this comment.
That's interesting, that seems to indicate that content became an optional field since the last time we touched the ToolsTab?
There was a problem hiding this comment.
ah, I think I know what's going on, we recently released tool structured output and we probably imported the new version of the TS SDK -- surprised now that CI didn't complain before ...
@bhosmer-ant would be good to add it to the inspector for testing as well
There was a problem hiding this comment.
okay, mystery solved! thank you @bhosmer-ant!!
I used local version of typescript sdk hence had this error, removed it
There was a problem hiding this comment.
Just leaving this thread open as a placeholder for the incoming SDK change mentioned elsewhere.
| @@ -234,7 +234,6 @@ const App = () => { | |||
| const onOAuthConnect = useCallback( | |||
| (serverUrl: string) => { | |||
| setSseUrl(serverUrl); | |||
| setTransportType("sse"); | |||
There was a problem hiding this comment.
Why is transport type no longer set here?
There are multiple reports on bot being able to connect to SSE and Streamable Http with Auth:
modelcontextprotocol/python-sdk#731
#390
modelcontextprotocol/python-sdk#679
SSE: due to auth provider - described here
Streamable Http - Auth flow was working fine, but when just clicking on connect, the request was hanging and then just timing out, instead of caching Auth error and re-triggering auth. The issue was that proxy was just masking errors and not returning them back to the client to be correctly handled during initialization. Unlike SSE, streamable Http does the first request on Initialization phase.
Testing:
Streamable Http Test:
SSE