chore(cli): improve test infrastructure#1020
Open
olaservo wants to merge 4 commits intomodelcontextprotocol:mainfrom
Open
chore(cli): improve test infrastructure#1020olaservo wants to merge 4 commits intomodelcontextprotocol:mainfrom
olaservo wants to merge 4 commits intomodelcontextprotocol:mainfrom
Conversation
- Move express from dependencies to devDependencies (only used in tests) - Add defensive check for child.pid in cli-runner.ts - Extract test URIs to constants (TEST_URI_ENV, TEST_URI_RESOURCE) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
olaservo
commented
Jan 19, 2026
| resources: [ | ||
| { | ||
| uri: "test://resource", | ||
| uri: TEST_URI_RESOURCE, |
Member
Author
There was a problem hiding this comment.
This seems a bit extra but Claude really wanted to make this a constant :)
cliffhall
requested changes
Jan 26, 2026
| } else if (child.pid) { | ||
| // On Unix, kill the process group | ||
| process.kill(-child.pid!, "SIGTERM"); | ||
| process.kill(-child.pid, "SIGTERM"); |
Member
There was a problem hiding this comment.
Why the dash before child.pid? It should be a number, but I don't think it should be negative.
| resources: [ | ||
| { | ||
| uri: "test://resource", | ||
| uri: TEST_URI_RESOURCE, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fast follow improvements to the CLI test infrastructure from PR #1012:
expressfromdependenciestodevDependenciesin cli/package.json (it's only used for test HTTP servers)child.pidbefore process kill in cli-runner.tstest://env,test://resource) to named constants for better maintainabilityTest plan
npm testpasses🦉 Generated with Claude Code