Skip to content

Conversation

@maciej-kisiel
Copy link
Contributor

@maciej-kisiel maciej-kisiel commented Jan 28, 2026

It's causing some servers to fail: #767. I checked with Typescript implementation and it doesn't do any escaping.

It's still a behavior change.

Fixes #238
Fixes #767

@jba
Copy link
Contributor

jba commented Jan 29, 2026

We should provide a way to preserve the old behavior. We don't know who depends on it.
See #238.
For example code, see https://github.com/google/jsonschema-go/blob/main/jsonschema/infer.go#L138.

@maciej-kisiel
Copy link
Contributor Author

Added a simple package to allow specifying compatibility flag as suggested in #238.

@maciej-kisiel maciej-kisiel force-pushed the mkisiel/json-escaping branch 2 times, most recently from e867a66 to 23e3ee4 Compare January 30, 2026 14:28
@maciej-kisiel maciej-kisiel marked this pull request as ready for review January 30, 2026 14:49
@maciej-kisiel maciej-kisiel requested a review from jba January 30, 2026 14:49
Copy link
Contributor

@jba jba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mistaken approval

@maciej-kisiel maciej-kisiel requested a review from jba January 30, 2026 15:29
@maciej-kisiel maciej-kisiel merged commit bba5acd into main Jan 30, 2026
8 checks passed
@maciej-kisiel maciej-kisiel deleted the mkisiel/json-escaping branch January 30, 2026 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

StreamableHTTP transport timeout issue. Idea: environment variable for experiments and compatibility

4 participants