Repository navigation
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 097945fefa
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| %include ../../mcp/streamable_example_test.go httpmiddleware - | ||
| The callback runs before validation and dispatch. It does not run for batches | ||
| or requests rejected before message decoding. To observe those failures, wrap |
There was a problem hiding this comment.
For a stateless or ephemeral request whose EventStore.Open fails, ephemeralConnectOpts has already decoded the valid single-message body before connectStreamable returns without calling StreamableServerTransport.ServeHTTP, so OnRequestSummary is skipped even though this is neither a batch nor a pre-decoding rejection. The stated boundary therefore gives operators the wrong expectation for connection failures; describe the gap as any HTTP, authorization, session-routing, or connection rejection before the callback, then regenerate the published page.
AGENTS.md reference: AGENTS.md:L55-L58
Useful? React with 👍 / 👎.
This branch has not been deployed
1 participant
The troubleshooting guide's HTTP example buffered and printed each complete JSON-RPC body. That is useful during local debugging, but it also encourages recording tool arguments and other potentially sensitive request data.
Use
StreamableHTTPOptions.OnRequestSummaryin the example instead. The callback exposes the decoded method and message kind without exposingparams. The guide also explains the callback's coverage boundary and recommends body-free HTTP middleware for failures rejected before decoding.The example remains executable, and the generated
docs/troubleshooting.mdis updated from its source.Tests:
go test ./mcp ./internal/docsgo build ./...go test ./...AI assistance disclosure: I used Codex to inspect the newly added request-summary API and draft the documentation change; I reviewed the resulting code, generated docs, and test output.