Skip to content

Fix iframe size feedback loop on Linux/Windows #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ochafik merged 1 commit into from
Dec 1, 2025
Merged

Fix iframe size feedback loop on Linux/Windows #54

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 12 additions & 5 deletions src/app.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -745,18 +745,25 @@ export class App extends Protocol<Request, Notification, Result> {
*/
setupSizeChangeNotifications() {
let scheduled = false;

const sendBodySizeChange = () => {
if (scheduled) {
return;
}
scheduled = true;
requestAnimationFrame(() => {
scheduled = false;
const rect = (
document.body.parentElement ?? document.body
).getBoundingClientRect();
const width = Math.ceil(rect.width);
const height = Math.ceil(rect.height);
const el = document.body.parentElement ?? document.body;
const rect = el.getBoundingClientRect();
// Compensate for viewport scrollbar on Linux/Windows where scrollbars
// consume space. window.innerWidth includes scrollbar, clientWidth excludes it.
const scrollbarWidth =
window.innerWidth - document.documentElement.clientWidth;
// Use max of rect (includes CSS transforms) and scroll dimensions (content overflow).
const width = Math.ceil(
Math.max(rect.width, el.scrollWidth) + scrollbarWidth,
);
const height = Math.ceil(Math.max(rect.height, el.scrollHeight));
this.sendSizeChange({ width, height });
});
};
Expand Down