Use Tool as the input type in getToolUiResourceUri#274
Merged
antonpk1 merged 1 commit intomodelcontextprotocol:mainfrom Jan 15, 2026
Merged
Conversation
@modelcontextprotocol/ext-apps
@modelcontextprotocol/server-basic-react
@modelcontextprotocol/server-basic-vanillajs
@modelcontextprotocol/server-budget-allocator
@modelcontextprotocol/server-cohort-heatmap
@modelcontextprotocol/server-customer-segmentation
@modelcontextprotocol/server-map
@modelcontextprotocol/server-pdf
@modelcontextprotocol/server-scenario-modeler
@modelcontextprotocol/server-shadertoy
@modelcontextprotocol/server-sheet-music
@modelcontextprotocol/server-system-monitor
@modelcontextprotocol/server-threejs
@modelcontextprotocol/server-transcript
@modelcontextprotocol/server-video-resource
@modelcontextprotocol/server-wiki-explorer
commit: |
Contributor
Author
|
@antonpk1 You might have opinions on this as you wrote the function |
Collaborator
|
good catch! thanks |
antonpk1
approved these changes
Jan 14, 2026
Contributor
Author
|
Feel free to merge! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We replace the use of the raw type with
Partial<Tool>type from the MCP Typescript SDKMotivation and Context
The function name
getToolUiResourceUriimplies that the input value is aTool. The type should reflect such input. This allows people to input the entire Tool result into the function, rather than having to extract the tool_metathemselves and passing it into the function.I set it to
Partialto be backwards compatible with those who are currently inputting the_metaraw.How Has This Been Tested?
Test cases pass.
Breaking Changes
Not breaking. Using
PartialTypes of changes
Checklist