Restore educational comments in basic-server-* examples#228
Merged
jonathanhefner merged 1 commit intomodelcontextprotocol:mainfrom Jan 12, 2026
Merged
Restore educational comments in basic-server-* examples#228jonathanhefner merged 1 commit intomodelcontextprotocol:mainfrom
basic-server-* examples#228jonathanhefner merged 1 commit intomodelcontextprotocol:mainfrom
Conversation
@modelcontextprotocol/ext-apps
@modelcontextprotocol/server-basic-react
@modelcontextprotocol/server-basic-vanillajs
@modelcontextprotocol/server-budget-allocator
@modelcontextprotocol/server-cohort-heatmap
@modelcontextprotocol/server-customer-segmentation
@modelcontextprotocol/server-scenario-modeler
@modelcontextprotocol/server-system-monitor
@modelcontextprotocol/server-threejs
@modelcontextprotocol/server-wiki-explorer
commit: |
PR modelcontextprotocol#184 accidentally removed/reverted educational comments from `basic-server-react` and `basic-server-vanillajs` that were established in PR modelcontextprotocol#182. This restores consistency with the other basic-server examples (Vue, Svelte, Preact, Solid). Changes: - Add back the three-comment pattern explaining two-part registration - Restore full tool description ("as an ISO 8601 string") - Change vanillajs to return plain text instead of JSON (matching modelcontextprotocol#182) - Use local `resourceUri` variable instead of top-level constant Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
jonathanhefner
force-pushed
the
restore-182
branch
from
fd93425 to
8b8ecbe
Compare
antonpk1
approved these changes
Jan 12, 2026
ochafik
approved these changes
Jan 12, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #184 accidentally removed/reverted educational comments from
basic-server-reactandbasic-server-vanillajsthat were established in PR #182. This restores consistency with the other basic-server examples (Vue, Svelte, Preact, Solid).Changes:
resourceUrivariable instead of top-level constant