Skip to content

Conversation

@antonpk1
Copy link
Collaborator

Summary

  • Makes params optional in McpUiInitializedNotificationSchema to accept notifications sent without explicit params

Problem

Notifications like this were being rejected by schema validation:

await this.notification(<McpUiInitializedNotification>{
  method: "ui/notifications/initialized",
});

The schema required params to be present, even though an empty object {} has no required fields.

Test plan

  • Verify notifications without params are now accepted by the schema
  • Existing code that passes params: {} continues to work

🤖 Generated with Claude Code

Notifications sent without params (e.g., `{ method: "ui/notifications/initialized" }`)
were being rejected by the schema validation because params was required.
This makes params optional so notifications without explicit params are accepted.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
@antonpk1 antonpk1 requested a review from ochafik November 24, 2025 22:49
@ochafik ochafik merged commit 807c9a1 into main Nov 25, 2025
2 checks passed
@ochafik ochafik deleted the fix/optional-params-initialized-notification branch November 25, 2025 03:51
@gaoash
Copy link

gaoash commented Dec 20, 2025

@copilot Implement Enhanced Scenery (Clouds & Atmosphere)


Implement Workstream 4A-2: Enhanced Scenery (Clouds & Atmosphere) as defined in shred/prompts/workbreakdown/phase-4-visual-polish/4A-2-enhanced-scenery.md.

This involves:

  1. Updating src/render/Layers.ts:
    • Implement the HSL Shift Strategy for atmospheric perspective (Lightness+, Hue->Blue, Saturation- for distant layers).
    • Add "Mist" gradients to the bottom of background layers.
    • Simplify distant layers to be pure silhouettes.
  2. Updating src/render/Sky.ts:
    • Implement a procedural Cloud system.
    • Add cloud types (Cirrus, Altocumulus, Stratus) with specific altitudes and parallax speeds.
    • Render clouds as horizontal, soft-edged ellipses.
  3. Integration:
    • Ensure clouds and layers are drawn in the correct order to create depth.

Refer to shred/prompts/shred-design.md Section 2.6 for specific design values (parallax factors, cloud types, etc.).

Please verify your changes by running the game (if possible) or ensuring the code compiles and tests pass. Update shred/prompts/workbreakdown/phase-4-visual-polish/4A-2-enhanced-scenery.md status to Complete when done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants