fix: ensure E2E screenshot tests work consistently across CI and local#150
Merged
fix: ensure E2E screenshot tests work consistently across CI and local#150
Conversation
- Remove platform-specific browser channel (was using Chrome on macOS, Chromium in CI) - now uses default Chromium everywhere - Add Docker-based test scripts for CI-identical local testing: - `npm run test:e2e:docker` - run tests in Docker - `npm run test:e2e:docker:update` - regenerate golden screenshots - Regenerate golden screenshots using Docker/Linux environment 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
commit: |
jonathanhefner
approved these changes
Dec 15, 2025
Member
jonathanhefner
left a comment
jonathanhefner
left a comment
There was a problem hiding this comment.
If this works as a quick fix, then it seems good. I think the longer-term solution is to have the test recreate the golden screenshots on each run, such that the golden screenshots and the target screenshots are always on the same platform (OS, browser, font stack, etc).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
npm run test:e2e:docker- run tests in Dockernpm run test:e2e:docker:update- regenerate golden screenshotsTest plan
npm run test:e2e:docker)npm run test:e2e)🤖 Generated with Claude Code