fix: ui/tool-cancelled -> ui/notifications/tool-cancelled #118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit: |
There was a problem hiding this comment.
Pull request overview
This PR standardizes the notification path for tool cancellation by renaming ui/tool-cancelled to ui/notifications/tool-cancelled, ensuring consistency with the established naming convention for notifications in the MCP Apps protocol.
- Updates the notification name from
ui/tool-cancelledtoui/notifications/tool-cancelledin the specification - Updates the corresponding TypeScript example code to use the correct notification path
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ochafik
approved these changes
Dec 10, 2025
Collaborator
ochafik
left a comment
ochafik
left a comment
There was a problem hiding this comment.
Thanks! (Oh, and we don't have this event wired in yet in the sdk)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace instances of
ui/tool-cancelledwith the standardui/notifications/tool-cancelled