-
Notifications
You must be signed in to change notification settings - Fork 53
Closed
Labels
bugSomething isn't workingSomething isn't working
Description
I think we can remove carousel from this enum:
displayMode?: "inline" | "fullscreen" | "pip" | "carousel";
- Seems unnecessary to specify since it doesn't require any different treatment from
inline, assuming the arrow buttons are provided by the apps (which I think they should be, to avoid the complexity of communicating back and forth about whether we're at the start/end of the carousel) - Not to mention:
- Being a
carouselis something that the app would decide, and not something that the host should be telling the app to be - Plus, you could be an
inlinecarousel or afullscreencarousel, so having them on the same property wouldn't capture the full range of states - And apps are probably either always a carousel or always not a carousel. It's not so much a "mode" as it as a "layout"
- Being a
The one thing that gives me pause is that chatgpt apps spec does have a carousel option iirc. So maybe worth digging into why they have that, and what materially changes when that is specified?
adamesque and liady
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't working