Support incremental scope consent (SEP-835) #1084
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
halter73
commented
Dec 10, 2025
halter73
commented
- Properly handle path segments in issuer path
- Include port in resource comparison
- Fix the order the client searches for "/.well-known/oauth-authorization-server" and "/.well-known/openid-configuration" authorization server metadata to match what's described in https://modelcontextprotocol.io/specification/2025-11-25/basic/authorization#authorization-server-metadata-discovery
halter73
requested review from
MackinnonBuck,
eiriktsarpalis,
localden,
mikekistler and
stephentoub
stephentoub
reviewed
Dec 10, 2025
stephentoub
previously approved these changes
Dec 10, 2025
halter73
force-pushed
the
halter73/907
branch
from
59e1841 to
48a9f17
Compare
- Properly handle path segments in issuer path - Include port in resource comparison
halter73
force-pushed
the
halter73/907
branch
from
48a9f17 to
7860efe
Compare
…PRM document This is stricter than the TypeScript SDK which only checks that the resource prefix matches: https://github.com/modelcontextprotocol/typescript-sdk/blob/06a4fd2332cd0ba8884e18b21ef4f7d03dea7b0d/src/shared/auth-utils.ts#L25 However RFC 9728 makes it clear that the resource name must be identical. The resource value returned MUST be identical to the protected resource's resource identifier value into which the well-known URI path suffix was inserted to create the URL used to retrieve the metadata. If these values are not identical, the data contained in the response MUST NOT be used. If the protected resource metadata was retrieved from a URL returned by the protected resource via the WWW-Authenticate resource_metadata parameter, then the resource value returned MUST be identical to the URL that the client used to make the request to the resource server. If these values are not identical, the data contained in the response MUST NOT be used. https://datatracker.ietf.org/doc/html/rfc9728/#section-3.3
stephentoub
reviewed
Dec 12, 2025
stephentoub
approved these changes
Dec 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.