Only require two approvals for changes to doc/, library/ or verifast-proofs/
#351
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tautschnig
approved these changes
May 8, 2025
Member
|
Can we please also have 2 reviewers for doc so that challenges get two reviews? |
Author
Good callout; done. |
carolynzech
changed the title
library/ or verifast-proofs/doc/, library/ or verifast-proofs/
thanhnguyen-aws
approved these changes
May 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are making a lot of changes to our
scripts/and.github/workflows/folders to improve automation. These changes are low-risk; we have no plans to upstream them and they're not part of the public-facing challenge effort. Update our workflow to require two committee approvals iffdoc/,library/orverifast-proofs/are modified, and otherwise just require one.See carolynzech#35 and carolynzech#36 for test runs on my fork.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.