Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Harness for CStr::is_empty #194

Merged
merged 6 commits into from
Dec 1, 2024
Merged

Harness for CStr::is_empty #194

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
cce570c
Add contracts and harness for from_bytes_with_nul_unchecked
Yenyun035 Nov 28, 2024
fa45330
Add is_empty harness
Yenyun035 Nov 28, 2024
ef7e100
Merge branch 'main' into c-0013-yenyunw-is-empty
Yenyun035 Nov 28, 2024
1c35aa1
Merge branch 'main' into c-0013-yenyunw-is-empty
Yenyun035 Nov 29, 2024
19def6e
Merge branch 'main' into c-0013-yenyunw-is-empty
Yenyun035 Nov 29, 2024
9d4476f
Small optimization of arbitray_cstr
Yenyun035 Nov 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Small optimization of arbitray_cstr
  • Loading branch information
@Yenyun035
Yenyun035 committed Nov 30, 2024
commit 9d4476feea2819fa6691837a8933719ae33237c4
7 changes: 5 additions & 2 deletions library/core/src/ffi/c_str.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -860,8 +860,11 @@ mod verify {

// Helper function
fn arbitrary_cstr(slice: &[u8]) -> &CStr {
// At a minimum, the slice has a null terminator to form a valid CStr.
kani::assume(slice.len() > 0 && slice[slice.len() - 1] == 0);
let result = CStr::from_bytes_until_nul(&slice);
kani::assume(result.is_ok());
// Given the assumption, from_bytes_until_nul should never fail
assert!(result.is_ok());
let c_str = result.unwrap();
assert!(c_str.is_safe());
c_str
Expand Down Expand Up @@ -946,7 +949,7 @@ mod verify {
const MAX_SIZE: usize = 32;
let string: [u8; MAX_SIZE] = kani::any();
let slice = kani::slice::any_slice_of_array(&string);
let c_str = arbitrary_cstr(slice); // introduced in PR#189
let c_str = arbitrary_cstr(slice);

let bytes = c_str.to_bytes(); // does not include null terminator
let expected_is_empty = bytes.len() == 0;
Expand Down
Loading