Skip to content

Implement f16 and f128 cases in codegen_float_type #3943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
carolynzech merged 1 commit into from
Mar 17, 2025
Merged

Implement f16 and f128 cases in codegen_float_type #3943

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions kani-compiler/src/codegen_cprover_gotoc/codegen/typ.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1400,11 +1400,10 @@ impl<'tcx> GotocCtx<'tcx> {

pub fn codegen_float_type(&self, f: Float) -> Ty<'tcx> {
match f {
Float::F16 => self.tcx.types.f16,
Float::F32 => self.tcx.types.f32,
Float::F64 => self.tcx.types.f64,
// `F16` and `F128` are not yet handled.
// Tracked here: <https://github.com/model-checking/kani/issues/3069>
Float::F16 | Float::F128 => unimplemented!(),
Float::F128 => self.tcx.types.f128,
}
}

Expand Down
15 changes: 15 additions & 0 deletions tests/kani/FloatingPoint/main.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@

#![feature(f16)]
#![feature(f128)]
#![feature(repr_simd)]

macro_rules! test_floats {
($ty:ty) => {
Expand Down Expand Up @@ -35,3 +36,17 @@ fn main() {
test_floats!(f64);
test_floats!(f128);
}

// Test that we can codegen floats when we hit them in codegen_float_type,
// c.f. https://github.com/model-checking/kani/issues/3069#issuecomment-2730501056
#[repr(simd)]
struct f16x16([f16; 16]);

fn make_float_array() -> f16x16 {
f16x16([1.0; 16])
}

#[kani::proof]
fn make_float_array_harness() {
let _ = make_float_array();
}
Loading