Update the rust toolchain to nightly-2024-06-11#3225
Merged
tautschnig merged 22 commits intomodel-checking:mainfrom Jun 11, 2024
Merged
Update the rust toolchain to nightly-2024-06-11#3225tautschnig merged 22 commits intomodel-checking:mainfrom
tautschnig merged 22 commits intomodel-checking:mainfrom
Conversation
Changes required due to: - rust-lang/rust@a34c26e7ec Make body_owned_by return the body directly. - rust-lang/rust@333458c2cb Uplift TypeRelation and Relate - rust-lang/rust@459ce3f6bb Add an intrinsic for `ptr::metadata` Resolves: model-checking#3218
tautschnig
changed the title
tautschnig
changed the title
tautschnig
changed the title
tautschnig
changed the title
feliperodri
approved these changes
Jun 10, 2024
celinval
reviewed
Jun 10, 2024
Contributor
celinval
left a comment
celinval
left a comment
There was a problem hiding this comment.
Looks good! Can you please also add tests for ptr_metadata for the other types of pointers? Like &dyn T and &char? Thanks!
celinval
suggested changes
Jun 10, 2024
Contributor
celinval
left a comment
celinval
left a comment
There was a problem hiding this comment.
I think the thin pointer case needs to be handled. Please double check
celinval
reviewed
Jun 10, 2024
Contributor
|
Ah... That's because we skip statements that generate zst values. It does make me wonder if that's appropriate. But that's a different problem. Thanks @tautschnig |
celinval
approved these changes
Jun 11, 2024
tautschnig
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes required due to:
ptr::metadataConstintoTyConstandMirConstResolves: #3218
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.