Implement kani::Arbitrary for Box<T>#2404
Merged
adpaco-aws merged 5 commits intomodel-checking:mainfrom Apr 25, 2023
Merged
Conversation
6415b66 to
ea83eec
Compare
zhassan-aws
reviewed
Apr 25, 2023
Contributor
zhassan-aws
left a comment
There was a problem hiding this comment.
I'm concerned about the soundness of the Arbitrary implementation. We need to make sure the implementation covers all possible states a box can be in. I'm a bit unclear on whether this is the case with the current implementation.
celinval
approved these changes
Apr 25, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
This PR implements
ArbitraryforBox<T>. This is required for structs that#[derive(kani::Arbitrary)]and have members withBox<T>types.Resolved issues:
Resolves #2403
Call-outs:
uifolder. I moved them toexpectedbecause that seems to be a better place (no UI testing is done in those tests).Testing:
How is this change tested? Existing tests + new one.
Is this a refactor change? No.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.