Skip to content

Include rust git logs in toolchain update PRs #2333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

tautschnig
Copy link
Member

Description of changes:

Fetch the commit hashes that nightly builds correspond to and construct a git log for the changes between two nightly releases. This should simplify tracking down which upstream changes may cause our builds or tests to break.

See tautschnig#11 for an example of what the result looks like.

Resolved issues:

n/a

Related RFC:

n/a

Call-outs:

n/a

Testing:

  • How is this change tested? Tested in my fork (see above link).

  • Is this a refactor change? No.

Checklist

  • Each commit message has a non-empty body, explaining why the change was made
  • n/a Methods or procedures are documented
  • Regression or unit tests are included, or existing tests cover the modified code
  • My PR is restricted to a single feature or bugfix

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.

@tautschnig tautschnig requested a review from a team as a code owner April 3, 2023 15:05
Copy link
Contributor

@karkhaz karkhaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks very helpful, thank you!

Copy link
Contributor

@zhassan-aws zhassan-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tautschnig!

Fetch the commit hashes that nightly builds correspond to and construct
a git log for the changes between two nightly releases. This should
simplify tracking down which upstream changes may cause our builds or
tests to break.
@tautschnig tautschnig force-pushed the nightly-update-more-info branch from 3495b70 to 42a884d Compare April 4, 2023 11:31
@tautschnig tautschnig enabled auto-merge (squash) April 4, 2023 11:31
@tautschnig tautschnig merged commit a8f5a96 into model-checking:main Apr 4, 2023
@tautschnig tautschnig deleted the nightly-update-more-info branch April 4, 2023 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants