Fix infinite loop on stub resolution and improve error handling #2227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adpaco-aws
reviewed
Feb 23, 2023
Co-authored-by: Adrian Palacios <73246657+adpaco-aws@users.noreply.github.com>
adpaco-aws
approved these changes
Feb 28, 2023
celinval
added a commit
to celinval/kani-dev
that referenced
this pull request
Mar 1, 2023
I just noticed a regression on model-checking#2227 where I incorrectly updated a test that should've caught this regression. Thus, fix the issue and revert the changes to the test.
celinval
added a commit
to celinval/kani-dev
that referenced
this pull request
Mar 1, 2023
I just noticed a regression on model-checking#2227 where I incorrectly updated a test that should've caught this regression. Thus, fix the issue and revert the changes to the test.
4 tasks
celinval
added a commit
that referenced
this pull request
Mar 1, 2023
I just noticed a regression on #2227 where I incorrectly updated a test that should've caught this regression. Thus, fix the issue and revert the changes to the test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Refactor the name resolution code to take into consideration loops added by loops in globs. Since I had to do some refactoring, I also ensured we now the reason why the resolution failed and print it as part of the error.
Resolved issues:
Resolves #2013 and resolves #2201
Related RFC:
Call-outs:
Testing:
How is this change tested? New tests
Is this a refactor change? Kinda
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.