-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate unit test line by line (for --inplace) #2213
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
… into Generate-test-by-line
… into Generate-test-by-line
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's looking good. I was wondering if we should modify the TempFile
slightly. So, we don't want to delete the file if it doesn't exist anymore. We should also consider bringing the BufWriter
to be inside this structure since we want to explicitly call flush()
before dropping it and before removing the file.
…nerate-test-by-line
… into Generate-test-by-line
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thanks again. Not for this PR, but we should eventually change this code to write all the unit tests in the file at once.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jaisnan. Just tiny comments
…nerate-test-by-line
… into Generate-test-by-line
Description of changes:
This PR adds -
The reason to generate the unit tests line by line is -
Resolved issues:
Closes the changes proposed by #1625
Call-outs:
Testing:
How is this change tested? unit tests but not
Is this a refactor change? yes
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.