-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix cbmc-viewer ci issues with Mac11 #1844
Changes from all commits
a76deb2
fc95757
b3721da
279ddd2
dfea781
c855da3
713f980
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
#!/bin/bash | ||
# Copyright Kani Contributors | ||
# SPDX-License-Identifier: Apache-2.0 OR MIT | ||
|
||
set -eu | ||
|
||
# Install cbmc-viewer | ||
|
||
# Source kani-dependencies to get CBMC_VIEWER_VERSION | ||
source kani-dependencies | ||
|
||
if [ -z "${CBMC_VIEWER_VERSION:-}" ]; then | ||
echo "$0: Error: CBMC_VIEWER_VERSION is not specified" | ||
exit 1 | ||
fi | ||
|
||
set -x | ||
|
||
# brew doesn't recognize specific versions of viewer | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Are we likely to care? Should we ask the tap owners to keep pinned versions in the tap? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I can't imagine this becoming a problem since viewer isn't updated that often and also There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is the issue that's causing ci to break, I imagine - actions/runner-images#6507. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can we push the fix to unblock us and we can figure out a better long term plan later? If actions/runner-images#6507 gets fixed, we could probably just revert these changes. |
||
brew install aws/tap/cbmc-viewer | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is this always set at this point? Where is this tap added? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we're not installing a specific version, then we shouldn't need to source kani-dependencies.