Ref #61 -- Introduce generators for each integer field #528
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
berinhard
reviewed
Jul 29, 2025
Member
berinhard
left a comment
berinhard
left a comment
There was a problem hiding this comment.
I really like the idea of defining per-field generators methods. I'm only leaving the comment since this is on draft, but I think it's a good path to follow.
Comment on lines
+98
to
+102
| from django.db.backends.base.operations import BaseDatabaseOperations | ||
|
|
||
| return BaseDatabaseOperations.integer_field_ranges.get( | ||
| field_name, (-MAX_INT, MAX_INT) | ||
| ) |
Comment on lines
+80
to
+92
| warnings.warn( | ||
| "gen_integer() may cause overflow errors with Django integer fields due to " | ||
| "large default MAX_INT value. Consider using field-specific generators instead:\n" | ||
| "- gen_positive_small_integer() for PositiveSmallIntegerField\n" | ||
| "- gen_small_integer() for SmallIntegerField\n" | ||
| "- gen_regular_integer() for IntegerField\n" | ||
| "- gen_positive_integer() for PositiveIntegerField\n" | ||
| "- gen_big_integer() for BigIntegerField\n" | ||
| "- gen_positive_big_integer() for PositiveBigIntegerField\n" | ||
| "See model_bakery.random_gen documentation for more details.", | ||
| DeprecationWarning, | ||
| stacklevel=2, | ||
| ) |
Member
There was a problem hiding this comment.
Nice touch with the warning 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the change
A draft attempt to address #61
PR Checklist