This repository has been archived by the owner on Jul 15, 2024. It is now read-only.
Refactor reference mod #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JR1811
added
Bug/Inconsistency
|
Thanks for reminding me to change my packages to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clean-up of the project's structure.
Sidenote
I deliberately avoided creating an extra package (called
init) which would contain all the classes which branch out to the custom classes (likeModItems,ModBlocks,ModEvents). Instead, I placed those classes into their respective packages to make it easier to find for new people, who are not used to the project's structure yet.Adding javadoc notes for where the code has been explained in the wiki might be a good idea. An example for that is in the
ModEventsclass, since the methods in there are coming from different topics / pages.