2.0 naming changes #349
2.0 naming changes #349
Conversation
KiwiHawk
left a comment
KiwiHawk
left a comment
There was a problem hiding this comment.
I've commented on a couple of lines of code. I have a whole load of changes that I have tried to push to the PR but I'm not able to. I'm not sure why.
| seablock.lib.substingredient("angels-stone-crushed-dissolution", "angels-stone-crushed", "stone", 20) | ||
|
|
||
| -- Update results of ore processing since Angel's changed that to be less convenient | ||
| data.raw.recipe["angels-ore-chunk-mix3-processing"].results = {{ type = "item", name = "bob-bauxite-ore", amount = 4 }} |
There was a problem hiding this comment.
I don't understand why you have added this change. Please explain?
There was a problem hiding this comment.
The crystallization part was added because Angels changed crystallization to a 40/40 split of different ores. That makes SB unplayable. I think I sent a DM to you about that change.
However I have no clue how that made it into the naming PR. I've read through it multiple times and that shouldn't have been there.
There was a problem hiding this comment.
Previously Angel's Crystallization produced Bob's Ores. Now it produces 40/40 of Angel's Ores. Either way, nothing should change from Sea Block's perspective. Sea Block should just be overwriting these recipes.
I don't see how this is relevant to changing the results of a couple of the mixed output ore sorting recipes?
|
|
||
| data.raw.recipe["angels-ore-crushed-mix3-processing"].results = {{ type = "item", name = "bob-lead-ore", amount = 4 }} | ||
|
|
||
| data.raw.recipe["angels-ore-pure-mix2-processing"].results = {{ type = "item", name = "angels-platinum-ore", amount = 2 }} |
There was a problem hiding this comment.
This is already done elsewhere, in data-updates\misc.lua.
| west = makeextractorlayers(true, true), | ||
| } | ||
| extractor.crafting_categories = { "thermal-extractor" } | ||
| extractor.fixed_recipe = "thermal-extractor-water" |
There was a problem hiding this comment.
Why did you remove crafting_categories and fixed_recipe ?
There was a problem hiding this comment.
That somehow slipped into the logic PR where it was readded with the new sb- prefix.
| ["rock-chest", "sb-rock-chest"] | ||
| ], | ||
| "item": | ||
| [ |
There was a problem hiding this comment.
Removed .json migration of crushed stone to stone as it won't actually trigger. Crushed stone has been hidden, not removed.
Edit: I saw that you nilled crushed stone rather than hiding it. This is bad for mod compatibility and makes the game more likely to crash.
There was a problem hiding this comment.
Also removed the purple catalyst migrations. Purple catalysts haven't been released yet.
2 participants
Implements only naming changes made by
This does PR is NOT in a running state, it only implements name changes which will not be commented.