Make setattr silently fail on remote inodes #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit changes the setattr behavior so that if an inode is remote, the operation is a no-op. This means that programs like `wget` that used to fail on our s3 mounts will now succeed, but some of their operations will not do anything.
pawalt
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
pawalt
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
pawalt
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
pawalt
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
pawalt
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
pawalt
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
pawalt
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
|
I have tested that this fixes our |
thundergolfer
approved these changes
Aug 16, 2024
| if sync.write_status == WriteStatus::Remote { | ||
| return Err(InodeError::SetAttrNotPermittedOnRemoteInode(inode.err())); | ||
| let stat = sync.stat.clone(); | ||
| drop(sync); |
There was a problem hiding this comment.
Is this drop needed to address a compiler complaint? It gets dropped when this setattr returns doesn't it?
There was a problem hiding this comment.
Yes it's for the compiler. Not sure how else to handle it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit changes the setattr behavior so that if an inode is remote, the operation is a no-op. This means that programs like
wgetthat used to fail on our s3 mounts will now succeed, but some of their operations will not do anything.