Fix typing on FunctionCall.gather #3062
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwaskom
force-pushed
the
michael/2025-04-25-fix-function-call-gather-typing
branch
from
4356f21 to
792ee3d
Compare
mwaskom
force-pushed
the
michael/2025-04-25-fix-function-call-gather-typing
branch
from
792ee3d to
63e90f8
Compare
mwaskom
commented
Apr 25, 2025
| @@ -1667,7 +1668,7 @@ async def from_id( | |||
| return fc | |||
|
|
|||
| @staticmethod | |||
| async def gather(*function_calls: "_FunctionCall[Any]") -> list[Any]: | |||
| async def gather(*function_calls: "_FunctionCall[T]") -> typing.Sequence[T]: | |||
There was a problem hiding this comment.
Couldn't use ReturnType here since this is a staticmethod.
|
@prbot approve |
![modal-pr-review-automation[bot]](https://avatars.githubusercontent.com/in/335990?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
We made
modal.functions.gathergeneric in #2188 but I neglected to migrate this properly when introducingmodal.FunctionCall.gather. Simple fix.Fixes #3020