Add support for calling input plane server #3047
Draft
+183
−62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thecodingwizard
force-pushed
the
nathan/inputplane
branch
from
07ab4a6 to
9ab4bb5
Compare
thecodingwizard
force-pushed
the
nathan/multi-api
branch
from
b89de01 to
b75c423
Compare
thecodingwizard
force-pushed
the
nathan/inputplane
branch
7 times, most recently
from
ba32cc4 to
e538e85
Compare
mwaskom
reviewed
Apr 23, 2025
thecodingwizard
force-pushed
the
nathan/inputplane
branch
3 times, most recently
from
8fa9feb to
af53197
Compare
thecodingwizard
force-pushed
the
nathan/inputplane
branch
from
af53197 to
d8e86f2
Compare
thecodingwizard
force-pushed
the
nathan/inputplane
branch
from
d8e86f2 to
fac124f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for using
modal-clientto call an input plane server if theinternal_experimental_input_plane_urlsetting is set.Our immediate goal is to get a synmon running against the input plane server. Rather than implementing logic for
FunctionGetto return the input plane URL, we'll take a shortcut for now and just configure the input plane URL through environment variables we'll manually set when running the synmon.We plan to remove this environment variable before releasing this to users in any capacity.
This depends on #3024.