Skip to content

Conversation

@ehdr
Copy link
Contributor

@ehdr ehdr commented Oct 29, 2025

Note

Propagates Context cancellation/timeouts through HTTP requests and polling loops across images, invocations, queues, and sandboxes; adds a gRPC test validating deadline behavior.

  • Context propagation and cancellations:
    • Add ctx.Err() checks in long-running/polling loops: image.Build, pollFunctionOutput, queue.get/put/Iterate, Sandbox.Wait, SandboxService.List, ContainerProcess.Wait.
  • HTTP requests now context-aware:
    • Use http.NewRequestWithContext for blob PUT upload and GET download in function.go and invocation.go.
  • Tests:
    • Add modal-go/test/grpc_test.go with bufconn gRPC server to verify client respects context deadlines (timeout vs completes before deadline).

Written by Cursor Bugbot for commit 225ca42. This will update automatically on new commits. Configure here.

@ehdr ehdr requested a review from thomasjpfan October 29, 2025 15:05
cursor[bot]

This comment was marked as outdated.

@ehdr ehdr force-pushed the ehdr/function-timeouts branch from 1ef5a9d to 225ca42 Compare October 29, 2025 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants