Skip to content

Conversation

@freider
Copy link
Contributor

@freider freider commented Oct 10, 2025

Note

Introduce mise-based monorepo task management with Python bootstrap/protoc, JS build/protoc, Go/JS tests, a test-support deploy task, and ignore task markers.

  • Build/Tasks (mise monorepo):
    • Root mise.toml: Define monorepo tasks and tools (python 3.11, uv). Add tasks: :py-install, :py-protoc, :py-bootstrap, and :deploy-test-support (deploys Modal test support, writes .task_markers/last-test-support-deploy).
    • modal-js/mise.toml: Add Node 22 and tasks :bootstrap (npm i), :protoc (generate TS from ../modal-client/modal_proto/*.proto), :build, and :test (depends on //:deploy-test-support).
    • modal-go/mise.toml: Add Go 1.23 and :test task (depends on //:deploy-test-support).
  • Gitignore:
    • Ignore .task_markers.

Written by Cursor Bugbot for commit 351dbb7. This will update automatically on new commits. Configure here.


[tasks.test]
description = "Test go"
run = "go test -v -run ./test"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Incorrect Regex Pattern in Go Test Command

The go test command incorrectly uses -run ./test. The -run flag expects a regex pattern for test names, but ./test is a package path. This means tests in the ./test directory won't run, as the command will try to match test function names against the literal pattern ./test.

Fix in Cursor Fix in Web

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants