Modified hasCaptured Captor check to also inspect the number of expectations vs the number of captured values
#326
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Nice! Merge pending #324 |
Member
|
@DarrenBishop mind rebasing on |
Member
|
Contributor
Author
|
@bbonanno sorry just noticed this... will do |
…ectations vs the number of captured values
DarrenBishop
force-pushed
the
Enable_Captor_hasCaptured_to_check_number_of_captures_vs_expectations
branch
from
394013b to
6da4413
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented a number of negative-tests, mainly to verify useful failure information is provided.
I thought it would be useful to report as many failures as possible for any given run, in the hope that feedback about more things results in less wasted developer time.
I used
MockitoAssertionErrorto compose failure feedback for both size and content failures; I did experiment exception suppression, but it seems that suppressedAssertionErrors do not get any special treatment/representation in ScalaTest.