add support for SameSite=none in cookies #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@etrepum it would be really convenient for me if we could merge this and cut a tag with it, let me know your thoughts. Also, any reason not to switch over to rebar3 as the build system? And any reason not to use eunit macros in tests? |
|
I'd be happy to accept PRs to switch to rebar3 and/or refactor the tests to use eunit macros. The only reason it hasn't happened yet is that nobody has wanted it enough to contribute it! |
|
@etrepum thanks for the quick tagging, saves me time down the line. I may see if I can't at least do the rebar3 bit soon as that feels worthwhile. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Newer versions of the RFC6265BIS specify a value of "None" for SameSite in some cases.