Add resume() for async tests that trap exceptions #889
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
Mocha's async support is awesome, but it as a small deficiency for testing code that catches exceptions, most notably promise-based code or code using task.js. For example:
This pull request introduces a helper function hidden as a property of the
done
callback that catches its own exceptions and concludes the test the same way asdone
. This would let us use the following pattern:I would be very much OK with other names for
resume
likenext
, or a second callback if you think it would be a better choice.