Strip tab indentation in clean utility method
#883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It doesn't look like you test actually covers the tab case (the description says it does, but i don't see |
|
It does, but I'm using literal tab characters. I'm assuming you're looking at the diff on GitHub, which doesn't take any steps to ensure tabs render correctly in HTML. If you look at the patch file for the commit, you'll have an easier time seeing the tabs. Having said that, your confusion makes me wonder if using |
|
Yeah, might be a good thing. |
The `clean` method is intended to normalize function body indentation to be relative to the first line. Update the implementation to support tab-indented function bodies (in addition to space-indented bodies).
|
Happy to oblige, @bitwiseman |
|
Pulled this in over at https://github.com/mocha-breve/mocha-breve/commit/c31fd254d10495d9e0bc8d7fab2698488ecb6536 and published to npm here. |
tj
added a commit
that referenced
this pull request
Jun 13, 2013
Strip tab indentation in `clean` utility method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
cleanmethod is intended to normalize function body indentation tobe relative to the first line. Update the implementation to support
tab-indented function bodies (in addition to space-indented bodies).