Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log passed tests, not completed tests #872

Closed
wants to merge 1 commit into from
Closed

Log passed tests, not completed tests #872

wants to merge 1 commit into from

Conversation

grandvizier
Copy link

In an effort to separate tests the pass from tests that are pending, or failed; log the count of passed tests instead of the count of tests that completed. (completed !== passed)

NOTE: should probably have also changed ' %d %s complete' to reflect this change

@bitwiseman
Copy link
Contributor

Yes, you'd need to go back an change the format string as well before this request could be considered ready.
Are there tests that need to change to match this?
What does the output look like before and after your change?

This seems to me like a matter of preference. Perhaps you'd be better off implementing your own reporter instead of trying to push these changes down into the base reporter.

@tj tj closed this in 5d1df37 May 31, 2013
@tj
Copy link
Contributor

tj commented May 31, 2013

this covers your other one as well but I can't find it now haha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants