Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic error case test support #860

Closed
wants to merge 2 commits into from
Closed

Add basic error case test support #860

wants to merge 2 commits into from

Conversation

bitwiseman
Copy link
Contributor

I'd work on #270, but in order to do so and know if I fixed it I needed to have the build support checking behavior in expected error cases.

Turned on timeout tests as proof of concept.

I'd work on #270, but in order to do so and know if I fixed it I needed to have the build support checking behavior in error case.
Turned on timeout tests as proof of concept.
@bitwiseman
Copy link
Contributor Author

@visionmedia Can we merge this in, please?
It is a test-only change that open the door for testing of failure and error cases. Coverage in these scenarios is vital to the stability and reliablity of the product. I'm surprised no one has done this yet.

Significant improvement to error suite output as well.
@bitwiseman
Copy link
Contributor Author

@visionmedia said:

I'm all down for failure tests but I'd definitely prefer to use node so we have some more flexibility with the assertions.

Hmm... The problem is that we need to cover cases where there are uncaught exceptions. I guess I can go back to and write this in javascript, but really we don't want that - we want to know what happens when we call mocha from the command line.

@bitwiseman
Copy link
Contributor Author

@visionmedia - Ping?

@bitwiseman
Copy link
Contributor Author

@visionmedia - Any feedback? Do I need to reimplement in javascript?

@tj
Copy link
Contributor

tj commented Jun 13, 2013

well you can still use javascript to test exec()s that use the shell so it would be the same, just easier to keep platform / shell independent

@bitwiseman
Copy link
Contributor Author

Cool, will do.

@tj
Copy link
Contributor

tj commented Jul 1, 2013

closing for now just to clean up the queue a bit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants