-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add basic error case test support #860
Conversation
I'd work on #270, but in order to do so and know if I fixed it I needed to have the build support checking behavior in error case. Turned on timeout tests as proof of concept.
@visionmedia Can we merge this in, please? |
Significant improvement to error suite output as well.
@visionmedia said:
Hmm... The problem is that we need to cover cases where there are uncaught exceptions. I guess I can go back to and write this in javascript, but really we don't want that - we want to know what happens when we call mocha from the command line. |
@visionmedia - Ping? |
@visionmedia - Any feedback? Do I need to reimplement in javascript? |
well you can still use javascript to test exec()s that use the shell so it would be the same, just easier to keep platform / shell independent |
Cool, will do. |
closing for now just to clean up the queue a bit |
I'd work on #270, but in order to do so and know if I fixed it I needed to have the build support checking behavior in expected error cases.
Turned on timeout tests as proof of concept.