Skip to content

Conversation

@Lightning00Blade
Copy link
Contributor

@Lightning00Blade Lightning00Blade commented Dec 3, 2025

PR Checklist

Overview

A very simple (and rough) PR to show case where the issue is. It only unwraps modules default if present.

@mark-wiemer mark-wiemer marked this pull request as draft December 4, 2025 01:37
@mark-wiemer
Copy link
Member

Thanks @Lightning00Blade , can you add a unit test that would've failed before but passes with your code changes?

@Lightning00Blade Lightning00Blade marked this pull request as ready for review December 17, 2025 12:03
@Lightning00Blade
Copy link
Contributor Author

@mark-wiemer I added the requested tests verified they don't pass on main.

I also strongly want to emphasize that PR #5344 should be merged as well,
even without test as where this bug was happening was easier once I had similar patch applied to the one proposed in the PR.

@codecov
Copy link

codecov bot commented Dec 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.53%. Comparing base (9cc3ada) to head (e6c338e).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5563   +/-   ##
=======================================
  Coverage   93.52%   93.53%           
=======================================
  Files          57       57           
  Lines        4465     4469    +4     
  Branches      918      920    +2     
=======================================
+ Hits         4176     4180    +4     
  Misses        289      289           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super. I verified locally that this passes with the repro case in #5562 (comment). Just one more test and I think we'll be good to go! 🚀

@JoshuaKGoldberg JoshuaKGoldberg added the status: waiting for author waiting on response from OP or other posters - more information needed label Dec 17, 2025
@mark-wiemer mark-wiemer added status: needs review a maintainer should (re-)review this pull request and removed status: waiting for author waiting on response from OP or other posters - more information needed labels Dec 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status: needs review a maintainer should (re-)review this pull request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🐛 Bug: Can't ESM (default) import custom interfaces and reporters

3 participants