-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
fix: reporter options override #5544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
fix: reporter options override #5544
Conversation
|
@saranganet thanks for the PR, please review the failing checks :) |
- Move command-line args to end of config objects list for higher priority - Add special handling for reporter-option to ensure CLI overrides config file - Add comprehensive tests for all scenarios - Fixes regression introduced in v8.3.0
- Move command-line args to end of config objects list for higher priority - Add special handling for reporter-option to ensure CLI overrides config file - Add comprehensive tests for all scenarios - Fixes regression introduced in v8.3.0 Resolves: mochajs#5532
- Fixes issue with reporter options not being properly merged - Handles multiple --reporter-option flags correctly - Ensures CLI options override config file options - Fixes mochajs#5532
54b0701 to
85fda87
Compare
…ion for reporter option format\n- Ensure 'key=value' format is enforced\n- Improve error messages for invalid formats\n- Fixes mochajs#5532
…ensure consistent code style\n- Fix reporter option validation format\n- Ensure all tests pass locally
_Version
|
@mark-wiemer , the tests are passing locally, but when I am trying to push then its failing. Anyone else can help fix the push then please ping me. |
If you want help you'll need to be a little more specific 🙂. Just a simple "its failing" isn't enough info for us to know how to help you. What's failing? What are the errors you're seeing? What have you tried? What do you think is going on? Suggestions:
|
| "semver": "^7.7.2", | ||
| "sinon": "^9.0.3", | ||
| "typescript": "^5.8.3", | ||
| "typescript": "^4.9.5", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unrelated change, and not one we want in this PR. We don't want to downgrade the TypeScript dependency. Did this sneak in from some local testing, or maybe some odd merge conflict?
This PR will need to revert changes to package.json, package-lock.json, and .gitub/release-please/manifest.json. These files aren't necessary to change for this PR's intended purpose.
fixes #5532
Summary
Fixes the regression where command-line
--reporter-optionsparameter doesn't override .mocharc.yml settings. This issue was introduced in v8.3.0.Changes Made
reporter-optionto detect CLI usage and override config file valuesTest Coverage
The fix handles all scenarios:
--reporter-optionsand--reporter-optionaliases work=syntax workVerification