feat: include test duration in timeout error messages #5542
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enhance timeout error messages to include the actual test duration when available. This provides developers with more context when debugging slow tests that exceed their timeout threshold. Changes: - Modified _timeoutError() to accept optional duration parameter - Track start time on runnable instance to calculate duration - Include duration in error message when timeout fires or test finishes late - Add comprehensive tests for duration inclusion in timeout errors The error message now includes: 'Test ran for Xms' when duration is available, making it easier to understand how much longer the test took than the timeout. Fixes: #(issue number if applicable)
|
|
Contributor
|
seems good! |
mark-wiemer
added
the
semver-major
Member
|
@Jeet-Srivastava can you open an issue so we can consider the use-cases here? Changing reporter output is usually a semver-major change which would require some thought as to "do we make this a CLI flag first?" and other questions |
mark-wiemer
added
the
status: in triage
Author
|
Hi @mark-wiemer, as you can see @saranganet has raised the issue, and i have replied to him there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhance timeout error messages to include the actual test duration when available. This provides developers with more context when debugging slow tests that exceed their timeout threshold.
Changes:
The error message now includes: 'Test ran for Xms' when duration is available, making it easier to understand how much longer the test took than the timeout.