fix: fail with an informative error message on a file with a broken default import #5413
+39
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinslota
changed the title
4 tasks
Fail with an informative error message on a file with a broken default import.
martinslota
force-pushed
the
fix-mocha-default-import-error-message
branch
from
edb0e34 to
e171a5d
Compare
|
Nice :) cursory review looks good, I'll dive deep into this tomorrow as I'm still a new maintainer |
3 tasks
mark-wiemer
approved these changes
Aug 10, 2025
mark-wiemer
changed the title
mark-wiemer
changed the title
JoshuaKGoldberg
requested changes
Aug 12, 2025
…w the require error in case the import error is ERR_INTERNAL_ASSERTION
|
@martinslota can you resolve merge conflicts? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fail with an informative error message on a file with a broken default import.
PR Checklist
status: accepting prsOverview
Fail with an informative error message on a file with a broken default import.