Skip to content

fix: print error when internal cli error happens (more helpful than ERROR: null) #5344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

fix: print error when internal cli error happens (more helpful than ERROR: null) #5344

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dd88210
fix: print error when internal cli error happens
Rob--W Apr 27, 2025
7cda07e
Merge branch 'main' into print-helpful-error-in-worst-case
mark-wiemer Jun 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions lib/cli/cli.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@ exports.main = (argv = process.argv.slice(2), mochaArgs) => {
debug('caught error sometime before command handler: %O', err);
yargs.showHelp();
console.error(`\n${symbols.error} ${pc.red('ERROR:')} ${msg}`);
console.error(err);
Copy link

Copilot AI Jun 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider logging the error stack (e.g., console.error(err.stack || err)) instead of the error object itself to provide full context for debugging.

Suggested change
console.error(err);
console.error(err.stack || err);

Copilot uses AI. Check for mistakes.
process.exit(1);
})
.help('help', 'Show usage information & exit')
Expand Down