Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add docs for parallel and root hooks #4246

Merged
merged 1 commit into from
Jun 2, 2020
Merged

Conversation

boneskull
Copy link
Contributor

(this PR needs the changes from the boneskull/issue/2839-11ty-changes branch)

Build might not work until that one gets merged

@boneskull boneskull added area: documentation anything involving docs or mochajs.org semver-minor implementation requires increase of "minor" version number; "features" area: node.js command-line-or-Node.js-specific labels Apr 21, 2020
@boneskull boneskull self-assigned this Apr 21, 2020
@coveralls
Copy link

coveralls commented Apr 23, 2020

Coverage Status

Coverage remained the same at 93.565% when pulling 5100fb8 on boneskull/issue/2839-docs into 273dbbb on master.

@boneskull boneskull mentioned this pull request May 13, 2020
docs/index.md Outdated Show resolved Hide resolved
Copy link
Contributor

@craigtaub craigtaub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great docs. Small comment.


## Root Hook Plugins

> _New in v8.0.0._
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
> _New in v8.0.0._
> _New in v7.2.0._

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to discuss whether we want to do this in v7.2.0 or v8.0.0. I would prefer the latter, for marketing reasons. 😜

docs/index.md Outdated
There are a (minimum of) two workarounds for this:

1. `require('./setup.js')` or `import './setup.js'` at the top of every test file. Best avoided for those averse to boilerplate.
1. _Recommended_: Define root-level hooks in a required file, using the new (also as of v8.0.0) [Root Hook Plugin](#root-hook-plugins) system.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
1. _Recommended_: Define root-level hooks in a required file, using the new (also as of v8.0.0) [Root Hook Plugin](#root-hook-plugins) system.
1. _Recommended_: Define root-level hooks in a required file, using the new (as of v7.2.0) [Root Hook Plugin](#root-hook-plugins) system.

Copy link
Contributor

@outsideris outsideris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebasing on master needed to resolve conflict and render emoji in netlify preview.

@boneskull boneskull force-pushed the boneskull/issue/2839-docs branch 3 times, most recently from 3dcd491 to 5100fb8 Compare June 2, 2020 18:02
> this PR needs the changes from the `boneskull/issue/2839-11ty-changes` branch
@boneskull
Copy link
Contributor Author

kept these references as v8.0.0 above, and changed a reference to v7.3.0 to v8.0.0

@boneskull boneskull merged commit 63eb80b into master Jun 2, 2020
@boneskull boneskull deleted the boneskull/issue/2839-docs branch June 2, 2020 20:51
@boneskull boneskull added this to the next milestone Jun 2, 2020
@boneskull boneskull modified the milestones: next, v8.0.0 Jun 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: documentation anything involving docs or mochajs.org area: node.js command-line-or-Node.js-specific semver-minor implementation requires increase of "minor" version number; "features"
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants