Remove generated file from VCS

[ScottFreeCode]

Resolves #2615

[coveralls]

Coverage remained the same at 89.12% when pulling 25dd654 on no-generated-file into f01f66e on master.

[ScottFreeCode]

Do we have any mentions of Bower support we would need to edit away for this too?

[boneskull]

Yes, so, bower.json needs to be removed, and we will need to update any relevant documentation.

I'm not sure if we need to do anything with Bower itself, like deprecate the package or whatever. Please open an issue here or hit someone up in Discord chat...

[boneskull]

• remove bower.json
• contact Bower team if necessary
• we may need to change how we're using the browser field of package.json and just do that stuff on the command-line, then point browser to mocha.js. this may impact users who are bundling Mocha themselves, but maybe not.
• ensure mocha.js is in files field of package.json
• (we cannot move mocha.js because modules like karma-mocha have hardcoded this path)

[boneskull]

This will also likely break mocha init.

[ScottFreeCode]

This will also likely break mocha init .

Only for usage from git, right? From NPM mocha init should just keep using the published file?

•we may need to change how we're using the browser field of package.json and just do that stuff on the command-line, then point browser to mocha.js . this may impact users who are bundling Mocha themselves, but maybe not.

I'm not clear why our workflow in this regard would be affected; this may be a good change to make but if we're still publishing the same stuff it shouldn't be necessitated by the removal of the built file from version control.

•contact Bower team if necessary

There's an unregister command, but I don't know if we want to unregister it given that versions < 4 should continue to work... Asking around and will update here when I have anything to show for it.

•remove bower.json
•ensure mocha.js is in files field of package.json

Will update these now...

[ScottFreeCode]

mocha.js is already in package.json's files; bower.json used to be in it, removed that. Also removed bower.json

[ScottFreeCode]

According to bower/bower#2482, I believe the idea is to make a copy of this repo containing only the old versions, then point Bower to that instead of this repo, then leave that repo as-is unless and until we have a need to change anything on Bower.

@boneskull Do you have the Bower permissions needed to do that?

[boneskull]

no, I didn't register it initially. you'll just have to ask them to change it--please let me know if you need assistance

[boneskull]

Only for usage from git, right? From NPM mocha init should just keep using the published file?

Yeah, you're right, n/m

From what I understand from that issue, basically all we need to do is remove bower.json when we tag v4.0.0. This will break users who have depended on mocha: "*", but really, that's not our problem.

[boneskull]

so, I think I'm gonna close this. I don't think we need to muck with browser for now, since it won't affect our builds.