Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade deps; closes #3018 (WIP--DO NOT MERGE) #3024

Merged
merged 17 commits into from
Sep 29, 2017
Merged

upgrade deps; closes #3018 (WIP--DO NOT MERGE) #3024

merged 17 commits into from
Sep 29, 2017

Conversation

boneskull
Copy link
Contributor

@boneskull boneskull commented Sep 28, 2017

upgrades: production

  • commander
  • debug
  • diff
  • glob
  • supports-color
  • browserify (affects production)

upgrades: development

  • karma-phantomjs-launcher
  • karma
  • karma-sauce-launcher

modules added

  • buffer

modules removed

  • lodash.create
  • phantomjs (installed via karma-phantomjs-launcher instead)
  • readable-stream
  • json3 (this was for IE7/8's crap implementation)

@boneskull boneskull added the semver-major implementation requires increase of "major" version number; "breaking changes" label Sep 28, 2017
@boneskull boneskull added this to the v4.0.0 milestone Sep 28, 2017
@boneskull boneskull self-assigned this Sep 28, 2017
@boneskull boneskull changed the title upgrade deps; closes #3018 (WIP) upgrade deps; closes #3018 (WIP--DO NOT MERGE) Sep 28, 2017
@boneskull
Copy link
Contributor Author

The story on buffer is that browserify@14.4.0 ships with buffer@5 which is incompatible with IE10 and older. So we have to explicitly depend on buffer@4 and tell browserify to use it.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 62aefdc on issue/3018 into ** on master**.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 3bd12d8 on issue/3018 into ** on master**.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 89.047% when pulling 1c2543e on issue/3018 into 0ed5297 on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 89.154% when pulling 7862a9b on issue/3018 into 0ed5297 on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 89.193% when pulling 00b1116 on issue/3018 into 0ed5297 on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 89.193% when pulling 3833a74 on issue/3018 into 0ed5297 on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 89.193% when pulling 3287c7f on issue/3018 into 0ed5297 on master.

@boneskull boneskull force-pushed the issue/3018 branch 2 times, most recently from 7e6f2dd to f1baaad Compare September 29, 2017 18:27
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.004%) to 89.174% when pulling f1baaad on issue/3018 into 228dc47 on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.004%) to 89.174% when pulling 05118d0 on issue/3018 into 228dc47 on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.004%) to 89.174% when pulling d4b1289 on issue/3018 into 228dc47 on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.004%) to 89.174% when pulling d4b1289 on issue/3018 into 228dc47 on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 89.3% when pulling 9f7d4bd on issue/3018 into 228dc47 on master.

@boneskull boneskull mentioned this pull request Sep 29, 2017
@boneskull
Copy link
Contributor Author

okay, I'm going to merge this. maybe a bit of rebasing but I'll try to keep things separated.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 89.3% when pulling 4554ceb on issue/3018 into 228dc47 on master.

@boneskull boneskull merged commit 16ffca2 into master Sep 29, 2017
@boneskull boneskull deleted the issue/3018 branch September 29, 2017 23:49
@boneskull boneskull removed their assignment Dec 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-major implementation requires increase of "major" version number; "breaking changes"
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants