Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hook error in browser reporter by moving body prop from test to runnable #2115

Merged
merged 1 commit into from
Feb 17, 2016
Merged

Fix hook error in browser reporter by moving body prop from test to runnable #2115

merged 1 commit into from
Feb 17, 2016

Conversation

danielstjules
Copy link
Contributor

Fixes Uncaught TypeError: Cannot read property 'replace' of undefined when an exception is thrown from a hook.

Example test suite that correctly renders after the PR:

before(function() {
  throw new Error('uh oh!');
});
it('test', function() {});

screen shot 2016-02-16 at 6 25 46 pm

danielstjules added a commit that referenced this pull request Feb 17, 2016
Fix hook error in browser reporter by moving body prop from test to runnable
@danielstjules danielstjules merged commit e290bc0 into mochajs:master Feb 17, 2016
@danielstjules danielstjules deleted the dstjules/fix-browser-hooks branch February 17, 2016 02:40
@andrei-picus-hs
Copy link

Why hasn't this been published to npm?!

@screendriver
Copy link

+1 for a release because I can't use Test'ems CI feature. My CI builds are hanging forever because the browser will not be closed when mocha isn't failing correctly 😭

@stevebartholomew
Copy link

Presume this is a regression as the same issue was fixed a while ago: #270 - +1 for release :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants