Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tests for newer versions of should.js #2033

Merged
merged 1 commit into from
Jan 6, 2016

Conversation

tomhughes
Copy link
Contributor

Review on Reviewable

@danielstjules
Copy link
Contributor

Thanks for the PR! Looks like the jobs failed with several errors. You can run the full test suite yourself using make test-all or npm test

@tomhughes
Copy link
Contributor Author

Think I've figured it out - there is an extra line in the stack traces now. Instead of:

      AssertionError: expected 'foo rar baz' to be 'foo bar baz'
      + expected - actual

      -foo rar baz
      +foo bar baz

      at Assertion.prop.(anonymous function) (node_modules/should/lib/should.js:61:14)
      at Context.<anonymous> (test/integration/fixtures/diffs/diffs.js:12:19)
      at callFn (lib/runnable.js:312:21)

we get:

      AssertionError: expected 'foo rar baz' to be 'foo bar baz'
      + expected - actual

      -foo rar baz
      +foo bar baz

      at Assertion.fail (node_modules/should/lib/assertion.js:91:17)
      at Assertion.Object.defineProperty.value (node_modules/should/lib/assertion.js:163:19)
      at Context.<anonymous> (test/integration/fixtures/diffs/diffs.js:12:19)
      at callFn (lib/runnable.js:312:21)

so we need to discard one more line when extracting the diff.

I've pushed an updated version that now passes.

@danielstjules
Copy link
Contributor

Thanks! It's unfortunate that the trace is a bit noisier, but at least we'll be using a recent release :)

danielstjules added a commit that referenced this pull request Jan 6, 2016
Update tests for newer versions of should.js
@danielstjules danielstjules merged commit 21b5436 into mochajs:master Jan 6, 2016
@tomhughes tomhughes deleted the should branch January 28, 2016 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants